Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interaction support for View.message and add disable_on_timeout to Views #1492

Merged
merged 11 commits into from
Jul 17, 2022
Merged

Add interaction support for View.message and add disable_on_timeout to Views #1492

merged 11 commits into from
Jul 17, 2022

Conversation

WhoIsConch
Copy link
Contributor

Summary

This pull requests defines a message for Views when sent as an interaction response. It also adds a new disable_on_timeout argument to ui.View to automatically disable all View components on the view's timeout.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Lulalaby Lulalaby enabled auto-merge (squash) July 11, 2022 16:45
@Lulalaby
Copy link
Member

Thanks conchy ♥️

@Lulalaby Lulalaby added Merge with squash feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Jul 11, 2022
@Lulalaby Lulalaby added this to the v2.1 milestone Jul 11, 2022
@Lulalaby Lulalaby requested a review from Dorukyum July 11, 2022 16:47
baronkobama
baronkobama approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@baronkobama baronkobama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby requested a review from Middledot July 15, 2022 04:07
Middledot
Middledot approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@Middledot Middledot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lulalaby Lulalaby merged commit 283db54 into Pycord-Development:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum left review comments

@Middledot Middledot Middledot approved these changes

@baronkobama baronkobama baronkobama approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@WhoIsConch WhoIsConch

Labels
feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: Done
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
5 participants
@WhoIsConch @Lulalaby @Dorukyum @baronkobama @Middledot