Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VoiceChannel/CategoryChannel data being invalidated on Option._invoke #1490

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

baronkobama
Copy link
Contributor

Summary

Prior to this PR, with the introduction of #1365, data was missing from the payloads that are directed to VoiceChannel._update and CategoryChannel._update via Option._invoke. This caused certain attributes of channels of these types to become completely invalid, causing issues such as #1483. This PR implements the same fix that was used to avoid this issue for TextChannel._update for the other 2 types of channels mentioned above (this should've already been done, but was an oversight on my part).

Closes #1483

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Lulalaby Lulalaby enabled auto-merge (rebase) July 10, 2022 23:17
@Lulalaby Lulalaby requested a review from Dorukyum July 10, 2022 23:17
@Lulalaby Lulalaby added this to the v2.1 milestone Jul 10, 2022
@Lulalaby Lulalaby added the bug Something isn't working label Jul 10, 2022
@Lulalaby Lulalaby merged commit fedee05 into Pycord-Development:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

discord.utils.get TypeError on Voice Channel Search
4 participants