Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce need for Permissions TypeVar #1324

Merged
merged 1 commit into from
May 5, 2022

Conversation

TurnrDev
Copy link
Contributor

@TurnrDev TurnrDev commented May 5, 2022

Suggestion from #1183
Originally posted by @Lulalaby in #1183 (comment)

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1324 (fc77021) into permissions-v2 (8ae253f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           permissions-v2    #1324      +/-   ##
==================================================
- Coverage           33.52%   33.52%   -0.01%     
==================================================
  Files                  93       93              
  Lines               17554    17553       -1     
==================================================
- Hits                 5885     5884       -1     
  Misses              11669    11669              
Flag Coverage Δ
pytest 33.52% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/commands/core.py 17.52% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae253f...fc77021. Read the comment docs.

@TurnrDev
Copy link
Contributor Author

TurnrDev commented May 5, 2022

Shut up codecov, you're clearly drunk.

@Lulalaby Lulalaby merged commit e3f8203 into Pycord-Development:permissions-v2 May 5, 2022
@TurnrDev TurnrDev deleted the patch-1 branch May 16, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants