[Perms v2] Additional implementations #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## permissions-v2 #1303 +/- ##
==================================================
+ Coverage 33.46% 33.52% +0.06%
==================================================
Files 93 93
Lines 17575 17550 -25
==================================================
+ Hits 5881 5884 +3
+ Misses 11694 11666 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
not going to implement gateway events in this PR for now, otherwise it's ready |
krittick
added a commit
that referenced
this pull request
May 5, 2022
* Remove v1 from application commands * Remove permissions v1 from documentation * Add v2 attributes to commands * Fix permissions for groups * Use v2 in as_dict methods * Add new permission decorator * Add missing return * Allow both kwargs and decorators for permissions * Add guild_only decorator * Allow decorating a command * Remove permissions v1 from docs * Fix to_check in get_desynced_commands * merge master into permissions-v2 * Rename has_permissions to default_permissions * Document command permissions * Fix command permissions doc note * Remove note * Rename dm_permission to guild_only for parity * Fix imports * Fix kwarg name * Move permission attributes to parent class * Fix guild_only decorator * [Perms v2] Additional implementations (#1303) * Update discord/commands/core.py Co-authored-by: Jay Turner <[email protected]> * Reduce need for Permissions TypeVar * Update api.rst * merge permissionsv2 into master branch copy * apply code style fixes * apply code style fixes Co-authored-by: Dorukyum <[email protected]> Co-authored-by: Dorukyum <[email protected]> Co-authored-by: BobDotCom <[email protected]> Co-authored-by: Lala Sabathil <[email protected]> Co-authored-by: plun1331 <[email protected]> Co-authored-by: Jay Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Targets the permissions-v2 branch
Things that still need to be done:
APPLICATION_COMMAND_PERMISSIONS_UPDATEgateway event (same issue as above)Checklist
type: ignorecomments were used, a comment is also left explaining why