Convert interaction.data["guild_id"] to int in the KeyError fallback within process_application_commands #1262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the KeyError fallback in process_application_commands to actually function.
Summary
If an application command can't be found by its interaction ID, there's a fallback that attempts to find it by checking the command name and its guild_ids if they are set. However, the
guild_id
in interaction.data is a string whileSlashCommand.guild_ids
is a list of integers and so this would always fail, further resulting in commands being unregistered.Checklist
type: ignore
comments were used, a comment is also left explaining why