Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix normalizing video classification input #1213

Conversation

dudeperf3ct
Copy link
Contributor

@dudeperf3ct dudeperf3ct commented Mar 2, 2022

What does this PR do?

Fixes #1193

Additional comment: Added a new lambda temporary function to avoid pickling error while training on multiple gpus as proposed in facebookresearch/pytorchvideo#101

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1213 (e8fa233) into master (c38b6d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1213   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         284      284           
  Lines       12694    12696    +2     
=======================================
+ Hits        11547    11549    +2     
  Misses       1147     1147           
Flag Coverage Δ
unittests 90.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/video/classification/input_transform.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38b6d9...e8fa233. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! LGTM 😃 Just a small suggestion. @dudeperf3ct Could you also add a Fixed entry to the CHANGELOG?

flash/video/classification/input_transform.py Outdated Show resolved Hide resolved
flash/video/classification/input_transform.py Outdated Show resolved Hide resolved
@dudeperf3ct dudeperf3ct requested a review from ethanwharris March 2, 2022 10:50
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 😃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Mar 2, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Mar 2, 2022
@mergify mergify bot added the has conflicts label Mar 3, 2022
@mergify mergify bot removed the has conflicts label Mar 3, 2022
@ethanwharris ethanwharris merged commit 36377b7 into Lightning-Universe:master Mar 3, 2022
@dudeperf3ct dudeperf3ct deleted the bugfix/video-input-normalize branch March 4, 2022 06:58
ethanwharris added a commit that referenced this pull request Mar 30, 2022
ethanwharris added a commit that referenced this pull request Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default InputTransform for video classification provide no normalization
2 participants