Merge branch 'master' into bugfix/video-input-normalize

Lightning-Universe · Mar 3, 2022 · e8fa233 · e8fa233
2 parents e02f35e + c38b6d9
commit e8fa233
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 - Fixed normalizing inputs to video classification ([#1213](https://github.com/PyTorchLightning/lightning-flash/pull/1213))
 
+- Fixed examples (question answering), where NLTK's `punkt` module needs to be downloaded first. ([#1215](https://github.com/PyTorchLightning/lightning-flash/pull/1215/files))
+
 - Fixed a bug where DDP would not work with Flash tasks ([#1182](https://github.com/PyTorchLightning/lightning-flash/pull/1182))
 
 - Fixed DDP support for `VideoClassifier` ([#1189](https://github.com/PyTorchLightning/lightning-flash/pull/1189))

diff --git a/flash_examples/question_answering.py b/flash_examples/question_answering.py
@@ -13,8 +13,15 @@
 # limitations under the License.
 from flash import Trainer
 from flash.core.data.utils import download_data
+from flash.core.utilities.imports import example_requires
 from flash.text import QuestionAnsweringData, QuestionAnsweringTask
 
+example_requires("text")
+
+import nltk  # noqa: E402
+
+nltk.download("punkt")
+
 # 1. Create the DataModule
 download_data("https://pl-flash-data.s3.amazonaws.com/squad_tiny.zip", "./data/")