Feature/integration pytorch tabular #1098
Conversation
…n order to use pytorch tabular implementation
…all kind of models
# Conflicts: # flash/tabular/classification/model.py # flash/tabular/data.py # flash/tabular/regression/model.py # tests/tabular/classification/test_model.py
Actis92
requested review from
ananyahjha93,
Borda,
carmocca,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
for more information, see https://pre-commit.ci
…lar' into feature/integration-pytorch-tabular # Conflicts: # flash/tabular/regression/model.py # tests/tabular/regression/test_model.py
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
+ Coverage 85.86% 86.11% +0.24%
==========================================
Files 281 284 +3
Lines 12816 12866 +50
==========================================
+ Hits 11005 11080 +75
+ Misses 1811 1786 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
…lar' into feature/integration-pytorch-tabular
for more information, see https://pre-commit.ci
|
Thank you @ethanwharris for your comments 😃 I have done the changes that you have suggested, and I have done a refactoring of TabularClassifier, TabularRegressor because I have noticed that before I didn't set correctly metrics, loss functions, etc ... because it is needed to be set in the model defined by pytorch-tabular. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
In this PR I have integrated pytorch-tabular inside lightning flash, unsing the Adapter like what is already been done with icevision and pytorch-forecasting.
I have added some parameters inside TabularData in order to have all the info required by the different models implemented in pytorch tabular.
And I have added tests and cli for TabularRegressor
Fixes #950