Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Integrate backbones from PyTorch Tabular for tabular classification and regression tasks #950

Closed
ethanwharris opened this issue Nov 8, 2021 · 5 comments · Fixed by #1098
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ethanwharris
Copy link
Collaborator

🚀 Feature

Use the models from here: https://github.com/manujosephv/pytorch_tabular

TabNet would work as currently but also have the others as options

@ethanwharris ethanwharris added enhancement New feature or request help wanted Extra attention is needed labels Nov 8, 2021
@Actis92
Copy link
Contributor

Actis92 commented Nov 12, 2021

Hi @ethanwharris in the last weeks I have worked on Pytorch-Tabular so if you want I can try to help for the integration

@ethanwharris
Copy link
Collaborator Author

Hi @Actis92 That would be great! I'll assign you to the issue. Please reach out if you want to discuss / brainstorm anything. It looks like they have lightning modules for the models so we should be able to make it work with the flash.core.adapter.Adapter. You could look at our IceVision and PyTorch Forecasting integrations to see how we did it there 😃

@Actis92
Copy link
Contributor

Actis92 commented Jan 4, 2022

Hi @ethanwharris,
sorry for the delay in the answer but I was quite busy. I'm trying to do the integration using the Adapter like pytorch forecasting, let me know if for you is ok that I open the pull request in this way you can start to give a look in order to see if i'm going on the right path

@Actis92
Copy link
Contributor

Actis92 commented Jan 5, 2022

Hi @ethanwharris you can find the PR #1098

@ethanwharris
Copy link
Collaborator Author

Hey @Actis92 Awesome! Thanks for opening the PR, I'll take a look 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants