Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually retrieve the batch script contents #258

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Actually retrieve the batch script contents #258

merged 2 commits into from
Feb 4, 2023

Conversation

tazend
Copy link
Member

@tazend tazend commented Jan 20, 2023

  • Fixes some incomplete type complaints for pthread_mutex_t and slurm_addr_t
  • actually retrieves the batch-script content and returns it as a string

Closes #250

@tazend
Fixes "incomplete type" complaints
3309033 
cython always complaint about "incomplete type" for pthread_mutex_t
and sockaddr_storage.
They must be atleast defined with a "pass", which makes the complaint
go away.

Also reformat the imports a bit.
@tazend
Actually return the batch-script contents as a string.
7fdd941 
Previously it was just printed to stdout, so it wasn't really
useful when wanting to process the contents any further in a script
for example.
@tazend tazend force-pushed the feature/retrieve-batch-script branch from 7557f9b to 7fdd941 Compare February 3, 2023 21:51
@tazend tazend merged commit ffc419f into PySlurm:main Feb 4, 2023
tazend added a commit that referenced this pull request May 14, 2023
@tazend
Actually retrieve the batch script contents (#258)
32ae53a 
* Fixes "incomplete type" complaints

cython always complaint about "incomplete type" for pthread_mutex_t
and sockaddr_storage.
They must be atleast defined with a "pass", which makes the complaint
go away.

Also reformat the imports a bit.

* Actually return the batch-script contents as a string.

Previously it was just printed to stdout, so it wasn't really
useful when wanting to process the contents any further in a script
for example.

(cherry picked from commit ffc419f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovtorres giovtorres Awaiting requested review from giovtorres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slurm_job_batch_script can't return string
1 participant
@tazend