Fixed mem_per_cpu setting in job class #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently there are some more things that still had |
|
Hi, alright looks good thanks for catching it :). I will then also get this to the 21.08 branch. |
tazend
pushed a commit
that referenced
this pull request
Sep 11, 2022
* Fixed mem_per_cpu setting. * Fixed settings with mem_per_cp mentions.
|
Perfect, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello pyslurm developers,
This PR fixes the false renaming of the
mem_per_cpusetting in some of the job class functions, which was calledmem_per_cp. This is a/the similar problem that was concerned in #241.Since this problem is part of multiple versions (at least
22.05and21.08as far as I checked), and we did it this way in my last contribution, I do this against base branchmain, for you to easily back port it. If you want a different branch, let me know, I could change the base branch then.Thanks :)
Best,
Jonathan