-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wind): Add power law interpolation method for wind conversion #402
Conversation
Refer to PyPSA#231 for context.
Tests work locally, any pointers to what is going wrong in CI? @lkstrp |
This PR doesn't have permissions to get the CDS API secret because it comes from a fork, which causes these errors. We might want to change the trigger, or add a manual trigger that has permissions. But the Cutouts should also just be fully cached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In pypsa
and linopy
we now use static types. So always feel free to spam those in there if you touch anything. Long way to go for atlite
though.
And great to have you back 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Co-authored-by: Lukas Trippe <[email protected]>
for more information, see https://pre-commit.ci
Makes sense. |
Added quite some typing to the wind conversion now. Needs Hope that is agreed practice. |
Great, it is. The |
…lanation If auxiliary data is missing from the cutout.
Yeah, well, i am confused about the state of the annotations :), since I started reading into https://docs.python.org/3.11/whatsnew/3.11.html#pep-563-may-not-be-the-future . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Side note: Would it make sense to at some point split the wind_test
into multiple smaller tests?
Closes #231 .
Refer to issue for context. Implements the power law interpolation method as a new argument
to
cutout.wind
. Needs to be chosen manually for now.A suggested in the issue we retrieve 100m and 10m wind speeds and then calculate a wind shear exponent from those during cutout preparation.
Looks like the power law is preferred at least for turbine heights above wind blending (?) height (70m?). So this should most likely become the new default if we have 100m wind speeds available (as we have for ERA5).
TODOs:
Changes proposed in this Pull Request
Checklist
doc
.environment.yaml
,environment_docs.yaml
andsetup.py
(if applicable).doc/release_notes.rst
of the upcoming release is included.