Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright and licensing #40

Merged
merged 11 commits into from
Aug 12, 2019
Merged

Copyright and licensing #40

merged 11 commits into from
Aug 12, 2019

Conversation

euronion
Copy link
Collaborator

@euronion euronion commented Aug 9, 2019

I added new copyright and licensing information to all files and made
the repository (nearly) REUSE compliant.

Somehow some minor commits got mixed up in this PR (sorry, i don't want
make the effort of taking them out of this PR).

@coroa Please let me know if you agree with this.

@euronion euronion added the v0.1 label Aug 9, 2019
@euronion euronion requested a review from coroa August 9, 2019 11:26
README.md Outdated Show resolved Hide resolved
Renewable Energy Atlas Lite (Atlite)

Light-weight version of Aarhus RE Atlas for converting weather data to power systems data
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove the package doc string intentionally? It is what is displayed, when you import the library. And then ask for help for it, ie

import atlite
?atlite

Instead I would like to extend it with a link to the documentation and perhaps one or two very simple examples.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, multiple reasons:

  • Previous one was so out-of-date it was more confusing than helping.
  • The docstring was repeated in every section of the API ref. generated by automodule on readthedocs.org - not something beautiful to look at.
  • I didn't have a nice substitute.

I'd drop the examples (Pareto principle + we are working on nice examples in parallel). So I argue no need to open up a new frontier there IMHO.
Let's stick to a simple description, suggestion in the updated PR.

@coroa
Copy link
Member

coroa commented Aug 12, 2019

Thanks for that tedious work! Looks good and i would merge soonish, so that we do not pick up anymore conflicts!

@euronion
Copy link
Collaborator Author

Thanks for that tedious work! Looks good and i would merge soonish, so that we do not pick up anymore conflicts!

Happy to hear & you're welcome!
Agreed, let's hopefully merge soon, I have already some more local merge conflicts because of this.

@euronion
Copy link
Collaborator Author

I merged upstream into my local and resolved the merge conflicts.
Hopefully I didn't make a mistake out of lacking attention and sleep.

If you're ok with the result, then please push the button. :)

@coroa coroa merged commit cb2b6a2 into PyPSA:documentation Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants