fix: disable_progressbar in compute_availabilitymatrix #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
The function
compute_availabilitymatrix()
includes an option to disable the progress bar (disable_progressbar
). However, for non-parallel computation path (i.e., whennprocesses
isNone
, the code usestqdm
directly, w/o passing thedisable_progressbar
check. This PR fixes it. User is informed if progress bar is disabled.Why bother: it seems that progress bar makes computation much slower. For a test case (UA, solar availability matrix, local computation, nprocesses is None) disabling progress bar speeds the process from 2000 seconds to 760 seconds.
Similar behavior was observed for other atlite processes, such as
build_renewable_profiles
(rumor evidence).Closes #pypsa-eur/1090
Checklist
doc
.doc/release_notes.rst
of the upcoming release is included.