Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add dewpoint temperature #342

Merged
merged 3 commits into from
May 6, 2024

Conversation

ymiftah
Copy link
Contributor

@ymiftah ymiftah commented Mar 16, 2024

Closes # (if applicable).

Change proposed in this Pull Request

Adds dewpoint temperature to the list of features fetched from ERA5.

It is possible that existing data pipelines that expect only 2 variables for the temperature may experience breaks with the addition of the new column. Should this new feature be optional instead ?

Description

Added the dewpoint_temperature variable, consistent with the processing of existing temperature and soil temperature variables

Motivation and Context

Dewpoint temperature is a good indicator of climate comfort and predictor of electricity demand.

How Has This Been Tested?

Tested by preparing a Cutout from ERA5, verifying the dew point temperature is included.
Tested on python 3.10.12

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • I locally ran pytest inside the repository and no unexpected problems came up.
  • I have adjusted the docstrings in the code appropriately.
  • I have documented the effects of my code changes in the documentation doc/.
  • I have added newly introduced dependencies to environment.yaml file.
  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for including a test.

@fneum fneum merged commit 195bc79 into PyPSA:master May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants