Add tracking
keyword support for cutout.irradiation
#340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change proposed in this Pull Request
Add
tracking
keywords tocutout.irradiation
functions similar tocutout.pv
.Description
The underlying
SurfaceOrientation
andTiltedIrradiation
functions already have support for solar tracking options. However, there was no way of accessing this functionality through thecutout.irradiation
method.Motivation and Context
Allows access to the irradiation quantities of surfaces with solar tracking. Admittedly, this is a pretty niche use case, but easy to implement and still useful for some applications.
How Has This Been Tested?
Not very thoroughly. I used the
building_stock_weather_aggregation.ipynb
example to briefly test that thetracking="vertical"
keyword incutout.irradiation
impacts the output irradiation quantities as expected. Other than that, I'm relying on the underlyingSurfaceOrientation
andTiltedIrradiation
functions.I tried running
pytest
, but it seems the currentmaster
has some issues, and the tests seem to get stuck attest/test_preparation_and_conversion.py::TestERA5::test_data_module_arguments_era5
. I'm guessing this might be related to the Copernicus CDS undergoing maintenance?Type of change
Checklist
pytest
inside the repository and no unexpected problems came up.doc/
. (No changes to the documentation needed as far as I can tell)environment.yaml
file. (No new dependencies)doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contribution