Avoid f-strings for now #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the use of f strings from tomlgen module. The package metadata didn't set a minimum python version and fstrings don't work with python 3.5. To enable having the last release of setuptools-rust prior to setting the python_requires work with python 3.5 we need to have a release which will work for 3.5. With this change setuptools-rust should work fine with Python 3.5. So we can release this and then set the minimum supported python version to 3.6 and reintroduce the use of fstrings. Fixes PyO3#85
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the use of f strings from tomlgen module. The package
metadata didn't set a minimum python version and fstrings don't work
with python 3.5. To enable having the last release of setuptools-rust
prior to setting the python_requires work with python 3.5 we need to
have a release which will work for 3.5. With this change setuptools-rust
should work fine with Python 3.5. So we can release this and then set
the minimum supported python version to 3.6 and reintroduce the use of
fstrings.
Fixes #85