-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github Actions instead of Travis #78
Conversation
0ca7cce
to
21230ad
Compare
c4df7c0
to
0700061
Compare
Seems to be failing as expected, if you point the |
Agreed; it's pretty late here so I'm going to finish this tomorrow. Ideally in the morning but could be later in the day... |
As PyO3/pyo3#1179 is now merged, I'm testing this PR against the pyo3 master. Hopefully green! |
01128ce
to
c4a1244
Compare
I think I missed one of the toml files, so have pointed that one also at master and re-pushed. |
CI passed 🎉 . So this is blocked until PyO3 0.12.1 releases. |
😅 good to know that PR works in any event. |
c4a1244
to
007a3ed
Compare
PyO3 0.12 released and working nicely here! |
This is a follow-up to #77 which adds testing (by migrating to github actions).
This isn't ready to merge; on the way I found that I had to build a custom pyo3 branch to fix PyPy support.
I also had to fixup a few pieces of the setuptools-rust examples to behave better cross-platform!