Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup.cfg #319

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Fix setup.cfg #319

merged 2 commits into from
Mar 12, 2023

Conversation

yasuo-ozu
Copy link
Contributor

We are using setuptools-rust as a build dependency of poetry-1.4.0 (in Ubuntun container of GitHub Actions).

# ...
[tool.poetry.dependencies]
setuptools-rust = "*"

[build-system]
requires = ["setuptools", "setuptools_rust" , "wheel"]
build-backend = "setuptools.build_meta"

This cause some warnings like:

Preparing build environment with build-system requirements setuptools, setuptools_rust, wheelInvalid requirement (setuptools>=62.4; semantic_version>=2.8.2,<3; typing_extensions>=3.7.4.3) found in setuptools-rust-1.5.2 dependencies, skipping

This PR fix the warning.

@davidhewitt
Copy link
Member

Thanks, could you please add a CHANGELOG entry? I can then try to release this fix soon.

@yasuo-ozu
Copy link
Contributor Author

Thanks for comment. I updated CHANGELOG.

davidhewitt
davidhewitt approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt merged commit 336a03b into PyO3:main Mar 12, 2023
@yasuo-ozu yasuo-ozu deleted the pr_fix_setup_cfg branch March 13, 2023 04:57
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 30, 2023
@0-wiz-0
py-setuptools-rust: update to 1.6.0.
dd5968d 
## 1.6.0 (2023-04-27)
### Changed
- Prefer passing `--crate-type` option to cargo if "toolchain >= 1.64". [#322](PyO3/setuptools-rust#322)

### Fixed
- Fix a bug where rebuilding the library would cause any running processes using it to segfault. [#295](PyO3/setuptools-rust#295)
- Fix `setup.cfg` format for compatibility with "poetry==1.4.0". [#319](PyO3/setuptools-rust#319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasuo-ozu @davidhewitt