Pin Python used in emscripten CI to latest 3.10 patch version #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub has been rolling out a change to have
ubuntu-latestworkflows use Ubuntu 22.04. Once that change hit this repository, thetest-emscriptenCI job started to fail. That job (added in #244) specifically pins the Python version to 3.10.2, which is not available for Ubuntu 22.04.From what I can gather, 3.10.2 was chosen to match the version used by Pyodide for their CI tests. Since then, Pyodide switched their CI to use the latest patch version of 3.10 (they also ran into the same incompatibility issue with Ubuntu 22.04 runners).
So: let's have the
test-emscriptenCI job use the latest patch version of Python 3.10, instead of pinning to any particular patch version.Please note that the cache key used with
actions/cache@v3doesn't need to be changed- thepython-pathoutput fromactions/setup-python@v4includes the full Python version, so any patch version bumps to the Python version used will invalidate the cache.