respect quiet flag in cargo metadata
#256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
h-vetinari
reviewed
Jun 28, 2022
h-vetinari
reviewed
Jun 28, 2022
Comment on lines
+7
to
+15
| >>> format_called_process_error(subprocess.CalledProcessError( | ||
| ... 1, ['cargo', 'foo bar'], 'message', None | ||
| ... )) | ||
| "`cargo 'foo bar'` failed with code 1\\n-- Output captured from stdout:\\nmessage" | ||
| >>> format_called_process_error(subprocess.CalledProcessError( | ||
| ... -1, ['cargo'], 'stdout', 'stderr' | ||
| ... )) | ||
| '`cargo` failed with code -1\\n-- Output captured from stdout:\\nstdout\\n-- Output captured from stderr:\\nstderr' | ||
| """ |
There was a problem hiding this comment.
Great to see this tested! 👍
h-vetinari
reviewed
Jul 5, 2022
| @@ -210,21 +212,12 @@ def build_extension( | |||
|
|
|||
| # Execute cargo | |||
| try: | |||
| stderr = subprocess.PIPE if quiet else None | |||
There was a problem hiding this comment.
@davidhewitt
Looking over this again after 1.4.0 didn't help makes me wonder if this condition is not the wrong way around?
Shouldn't we not be listening for stderr output if quiet=True (or at least, be listening for it if quiet=False)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #254 to make the formatting reusable & tested, and respect
quietflag for stderr.