Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch distutils build command to use has_ext_modules() #150

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Patch distutils build command to use has_ext_modules() #150

merged 1 commit into from
Jun 28, 2021

Conversation

messense
Copy link
Member

Fixes #146

Upstream patch: pypa/distutils#43

davidhewitt
davidhewitt reviewed Jun 28, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it looks like this is a necessary trick for now!

setuptools_rust/setuptools_ext.py Outdated Show resolved Hide resolved
setuptools_rust/setuptools_ext.py Outdated Show resolved Hide resolved
@messense messense merged commit f6030f4 into PyO3:main Jun 28, 2021
@messense messense deleted the patch-distutils-build branch June 28, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: setup.py build does not put built binary under build/lib.*?
2 participants
@messense @davidhewitt