On *NIX systems, gather cross compiling info from sysconfig #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
reviewed
Mar 22, 2021
| @@ -112,12 +170,15 @@ def build_extension(self, ext: RustExtension, target_triple=None): | |||
| "PYO3_PYTHON": os.environ.get("PYO3_PYTHON", sys.executable), | |||
| } | |||
| ) | |||
|
|
|||
| if target_info.cross_lib: | |||
| env.setdefault("PYO3_CROSS_LIB_DIR", target_info.cross_lib) | |||
|
Thanks! I'm going to review this together with #134, as they look like two complimentary pieces of the puzzle to me. I confess I haven't tried cross-compiling Python projects. Have you got a recommended target to cross compile to which I can use to play around with this? |
davidhewitt
force-pushed
the
cross-compile-info-from-sysconfig
branch
from
a8f3e5c
to
035a402
Compare
davidhewitt
approved these changes
Mar 28, 2021
There was a problem hiding this comment.
Thanks very much for this. Sorry for the delayed review; I've had to do a fair bit of reading on crossenv and cross-compiling Python to give this review proper attention.
It looks to me like this change is beneficial in general (not just for crossenv) because reading sysconfig is generally a good idea.
I did a force-push to rebase and add a changelog entry.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138