Augment, rather than replace, existing RUSTFLAGS when building #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Feb 8, 2021
Some complex environments (like cross-compilation environments) may use RUSTFLAGS to control the behavior of rust compilation. Rather than overwriting RUSTFLAGS with compilation options determined in build.build_rust.build_extension, the extension-specific flags are now appended to any existing RUSTFLAGS to preserve the build environment.
|
I appreciate your quick response. The latest version includes a changelog entry and a slightly more descriptive commit message. |
|
Great, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some complex environments may use RUSTFLAGS to control the behavior of rust compilation. Rather than overwriting RUSTFLAGS with custom flags, augment any existing RUSTFLAGS to preserve these environments.
This is used, for example, by Void Linux to set
--sysroot=${XBPS_CROSS_BASE}/usrin cross-compilation environments to point to the target system root.