Skip to content

Commit

Permalink
Re-enable builds on 32-bit Windows
Browse files Browse the repository at this point in the history
The parent commit fixes the problems with 32-bit Windows, this one
simply re-enables the build and re-activates the CI runs of it.
  • Loading branch information
jakelishman committed Oct 21, 2024
1 parent 51299b2 commit 204d487
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ jobs:
python-architecture: "x64",
rust-target: "x86_64-pc-windows-msvc",
},
{
os: "windows-latest",
python-architecture: "x86",
rust-target: "i686-pc-windows-msvc",
},
]
include:
# ubuntu-24.04 does not support 3.7
Expand Down Expand Up @@ -141,6 +146,11 @@ jobs:
python-architecture: "x64",
rust-target: "x86_64-pc-windows-msvc",
},
{
os: "windows-latest",
python-architecture: "x86",
rust-target: "i686-pc-windows-msvc",
},
]
include:
# ubuntu-24.04 does not support 3.7
Expand Down Expand Up @@ -181,6 +191,7 @@ jobs:
nox -f examples/simple/noxfile.py
env:
CARGO_TERM_VERBOSE: true
CARGO_BUILD_TARGET: ${{ matrix.platform.rust-target }}
RUST_BACKTRACE: 1

cross-build:
Expand Down
3 changes: 0 additions & 3 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ as well as the [`PyReadonlyArray::try_as_matrix`] and [`PyReadwriteArray::try_as
// and similar aren't constructible
#![cfg_attr(feature = "gil-refs", deny(missing_debug_implementations))]

#[cfg(all(target_os = "windows", target_arch = "x86"))]
compile_error!("Compilation for 32-bit windows is not currently supported. See https://github.com/PyO3/rust-numpy/issues/448");

pub mod array;
mod array_like;
pub mod borrow;
Expand Down

0 comments on commit 204d487

Please sign in to comment.