Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for generating non-abi3 pythonXY.dll #15

Merged
merged 2 commits into from
May 10, 2022
Merged

Add support for generating non-abi3 pythonXY.dll #15

merged 2 commits into from
May 10, 2022

Conversation

messense
Copy link
Member

@messense messense commented May 9, 2022

Closes #12

@messense messense marked this pull request as draft May 9, 2022 13:04
@messense messense marked this pull request as ready for review May 9, 2022 13:12
ravenexp
ravenexp reviewed May 9, 2022
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
ravenexp
ravenexp reviewed May 9, 2022
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
ravenexp
ravenexp previously requested changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@ravenexp ravenexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but I'd like to keep backwards compatibility with v0.2 unless there's a pressing need to break it.

@messense messense requested a review from ravenexp May 10, 2022 02:56
ravenexp
ravenexp approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@ravenexp ravenexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new public interface looks nice, thanks everyone for suggesting and implementing it.

Are there plans to generate version-specific import libraries for the MSVC targets as well?
Then there should be at least some unit tests for that too.

@messense
Copy link
Member Author

Are there plans to generate version-specific import libraries for the MSVC targets as well?
Then there should be at least some unit tests for that too.

Added.

@messense messense merged commit 7bf8962 into PyO3:main May 10, 2022
@messense messense deleted the non-abi3 branch May 10, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejrs mejrs mejrs left review comments

@adamreichold adamreichold adamreichold left review comments

@ravenexp ravenexp ravenexp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support generating non-abi3 pythonXY.dll?
4 participants
@messense @ravenexp @adamreichold @mejrs