Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Rust version to 1.42.0-nightly #761

Merged
merged 4 commits into from
Feb 10, 2020

Conversation

davidhewitt
Copy link
Member

I fixed all the clippy warnings as of present.

To silence the safety warnings for now (#698) I've added an #![allow(clippy::missing_safety_doc)]. This should make it easier to check for new clippy errors when people are developing patches while we wait for someone to pick up #698.

@kngwyu
Copy link
Member

kngwyu commented Feb 9, 2020

Ooops, missing_safety_doc is from 1.39 https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#rust-139, so minimum_nightly fails in traivis.

Could you please update minimum nightly, or remove #![allow(clippy::missing_safety_doc)]?

@davidhewitt davidhewitt changed the title Fix clippy warnings Bump minimum Rust version to 1.42.0-nightly Feb 9, 2020
@davidhewitt
Copy link
Member Author

I've moved the minimum Rust version bump from #760 into this PR.

@kngwyu kngwyu force-pushed the fix-clippy-warnings branch 3 times, most recently from a1070ff to 2c6dc94 Compare February 10, 2020 05:13
@kngwyu kngwyu force-pushed the fix-clippy-warnings branch from 2c6dc94 to a6fed34 Compare February 10, 2020 05:53
@kngwyu
Copy link
Member

kngwyu commented Feb 10, 2020

Thank you!

@kngwyu kngwyu merged commit 1d33ac4 into PyO3:master Feb 10, 2020
@davidhewitt davidhewitt deleted the fix-clippy-warnings branch February 10, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants