Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back PyTuple::new #4380

Merged
merged 2 commits into from
Jul 28, 2024
Merged

add back PyTuple::new #4380

merged 2 commits into from
Jul 28, 2024

Conversation

davidhewitt
Copy link
Member

After reviewing #4378 I found myself itching to write a migration guide entry, so here's a first attempt at that. To support the guide with an example I added back new forms of PyTuple::new and PyTuple::empty and deprecated the _bound names for those.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jul 26, 2024
Copy link
Contributor

@Icxolu Icxolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo in the section heading

guide/src/migration.md Outdated Show resolved Hide resolved
@davidhewitt davidhewitt enabled auto-merge July 27, 2024 11:19
@davidhewitt davidhewitt added this pull request to the merge queue Jul 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 27, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Jul 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 27, 2024
@Icxolu Icxolu added this pull request to the merge queue Jul 28, 2024
Merged via the queue into PyO3:main with commit 7683c4a Jul 28, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants