Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for numpy 2.0 #4258

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Update tests for numpy 2.0 #4258

merged 1 commit into from
Jun 17, 2024

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 16, 2024

No description provided.

@alex alex added the CI-skip-changelog Skip checking changelog entry label Jun 16, 2024
@alex alex mentioned this pull request Jun 16, 2024
Merged
davidhewitt
davidhewitt approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I think this is worth a news fragment - maybe "added" - support conversion to bool for numpy 2 bools, perhaps?

Other than that, please merge 👍

@alex alex removed the CI-skip-changelog Skip checking changelog entry label Jun 16, 2024
@alex alex enabled auto-merge June 16, 2024 22:38
@alex alex added this pull request to the merge queue Jun 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 16, 2024
@alex alex enabled auto-merge June 16, 2024 23:45
@alex alex added this pull request to the merge queue Jun 17, 2024
Merged via the queue into PyO3:main with commit baae929 Jun 17, 2024
39 checks passed
@alex alex deleted the numpy-update branch June 17, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @davidhewitt