Add num-rational support for Python's fractions.Fraction type
#4148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
reviewed
May 1, 2024
|
Thanks for review @Icxolu. I have addressed your remarks :). |
Icxolu
reviewed
May 2, 2024
CodSpeed Performance ReportMerging #4148 will not alter performanceComparing Summary
|
Icxolu
reviewed
May 3, 2024
Icxolu
reviewed
May 9, 2024
src/conversions/num_rational.rs
Outdated
Comment on lines
166
to
177
| #[test] | ||
| fn test_fraction_as_tuples() { | ||
| Python::with_gil(|py| { | ||
| let locals = PyDict::new_bound(py); | ||
| let py_bound = py.run_bound( | ||
| "import fractions\npy_frac = fractions.Fraction(fractions.Fraction((10,)))", | ||
| None, | ||
| Some(&locals), | ||
| ); | ||
| assert!(py_bound.is_err()); | ||
| }) | ||
| } |
There was a problem hiding this comment.
I guess this was a bit unclear (and part of my fault for misremembering call1 from above), but what I meant was just the test of into_py (which you have in the prop tests below). This now just tests the behavior of fractions.Fraction which is not that useful for us. Perhaps we can instead add special case of the test_int_roundtrip that also runs on wasm32.
Then this is good to go 👍
There was a problem hiding this comment.
No problem! Hopefully this time is the charm :) Thanks for the review
Icxolu
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This should close #3105 by adding support for Python's
fractions.Fractiontype usingnum-rational.