Remove dead code in macros backend #4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Thanks! See also #4010, let's merge this one and I'll tidy the other PR up later.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Is https://github.com/PyO3/pyo3/actions/runs/8480976804/job/23237630151 a known flake? Don't see how it could be caused by this PR |
|
It makes sense to me why that's flaky, #4014 should resolve. |
Closed
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
I'm going to let the merge queue clear out before I re-add this. |
|
Yeah, need to think if there's anything else we can do to help CI run a little more efficiently... |
|
I filed a seperate bug as a place to ideate/track improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to PyO3!