Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add into_mapping and into_sequence methods to Bound types #3982

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Add into_mapping and into_sequence methods to Bound types #3982

merged 5 commits into from
Mar 23, 2024

Conversation

LilyFoote
Copy link
Contributor

@LilyFoote LilyFoote commented Mar 22, 2024 •
edited
Loading

Fixes #3981.

  • an entry for this PR in newsfragments - see [https://pyo3.rs/main/contributing.html#documenting-changes]
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

@davidhewitt
Copy link
Member

👍 thanks! Some tests would be great please 😄

@davidhewitt davidhewitt mentioned this pull request Mar 23, 2024
Merged
davidhewitt
davidhewitt approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for picking this up so quickly 🙏

@davidhewitt davidhewitt enabled auto-merge March 23, 2024 00:38
@davidhewitt davidhewitt added this pull request to the merge queue Mar 23, 2024
Merged via the queue into PyO3:main with commit 009cd32 Mar 23, 2024
42 of 43 checks passed
@LilyFoote LilyFoote deleted the into-methods branch March 23, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast dict to mapping and list to sequence, transferring ownership
2 participants
@LilyFoote @davidhewitt