Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy some usage of py.from_borrowed_ptr and py.from_borrowed_ptr_or_opt #3877

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Tidy some usage of py.from_borrowed_ptr and py.from_borrowed_ptr_or_opt #3877

merged 2 commits into from
Feb 23, 2024

Conversation

LilyFoote
Copy link
Contributor

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 20, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3877 will not alter performance

Comparing LilyFoote:tidy-from-borrowed-ptr (4de8b1a) with main (61bc02d)

Summary

✅ 67 untouched benchmarks

davidhewitt
davidhewitt reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few suggestions here mostly related to skipping unnecessary reference counting :)

pyo3-macros-backend/src/pymethod.rs Outdated Show resolved Hide resolved
src/impl_/pyclass.rs Outdated Show resolved Hide resolved
src/instance.rs Outdated Show resolved Hide resolved
@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 20, 2024
@LilyFoote LilyFoote force-pushed the tidy-from-borrowed-ptr branch from c21d9b5 to c602d8d Compare February 20, 2024 10:10
@LilyFoote LilyFoote mentioned this pull request Feb 22, 2024
Merged
davidhewitt
davidhewitt approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@davidhewitt davidhewitt added this pull request to the merge queue Feb 22, 2024
Merged via the queue into PyO3:main with commit 22a23ff Feb 23, 2024
40 checks passed
@LilyFoote LilyFoote deleted the tidy-from-borrowed-ptr branch February 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LilyFoote @davidhewitt