Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example for storing Py<T> in structs #3876

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

davidhewitt
Copy link
Member

As per #3775 (review)

There's a lot of documentation around the place which I'm sure needs updating; I'm hoping to take a pass at the guide later this week. For now, this is hopefully a start...

Copy link

codspeed-hq bot commented Feb 20, 2024

CodSpeed Performance Report

Merging #3876 will degrade performances by 15.02%

Comparing davidhewitt:update-example (769846e) with main (0bb9cab)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 77 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main davidhewitt:update-example Change
list_via_downcast 157.2 ns 185 ns -15.02%
sequence_from_list 355.6 ns 300 ns +18.52%

@davidhewitt davidhewitt added this pull request to the merge queue Feb 20, 2024
Merged via the queue into PyO3:main with commit 8ac7834 Feb 20, 2024
37 of 39 checks passed
@davidhewitt davidhewitt deleted the update-example branch February 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants