Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port PyComplex::from_complex to Bound API #3866

Merged
merged 2 commits into from
Feb 19, 2024

add `PyComplexMethods` to the prelude

db8e4b7
Select commit
Loading
Failed to load commit list.
Merged

port PyComplex::from_complex to Bound API #3866

add `PyComplexMethods` to the prelude
db8e4b7
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Feb 18, 2024 in 0s

Performance Regression: -10.2%

Summary

⚡ 4 improvements
❌ 1 regressions
✅ 74 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Icxolu:num-complex Change
extract_float_extract_success 500.6 ns 445 ns +12.48%
extract_str_downcast_success 728.9 ns 645.6 ns +12.91%
list_via_extract 364.4 ns 308.9 ns +17.99%
not_a_list_via_downcast 244.4 ns 272.2 ns -10.2%
sequence_from_tuple 267.2 ns 239.4 ns +11.6%