always use a Python iterator for sets and frozensets #3849
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3762
This removes the branching of
Py_LIMITED_API
/not(Py_LIMITED_API)
code for iterators ofset
andfrozenset
, opting to just use thePy_LIMITED_API
forms in all cases.This is slightly slower but recommended for stability due to use of private API
_PySet_NextEntry
which might also not work properly when iterating set subclasses (if they override iteration).At the same time I added
ExactSizeIterator
implementations to both iterators, as we had that previously just for thenot(Py_LIMITED_API)
case.Overall this is a code simplification and consistency improvement.