Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow from_py_with on function args to take a fn(&Bound) -> PyResult #3837

Merged
merged 1 commit into from
Feb 14, 2024

allow `from_py_with` on function args to take a `fn(&Bound) -> PyResult`

1a4a44d
Select commit
Loading
Failed to load commit list.
Merged

allow from_py_with on function args to take a fn(&Bound) -> PyResult #3837

allow `from_py_with` on function args to take a `fn(&Bound) -> PyResult`
1a4a44d
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Feb 14, 2024

Performance Regression: -15.63%

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Icxolu:from-py-with-pyfunction Change
❌ mapping_from_dict 300 ns 355.6 ns -15.63%
⚡ f64_from_pyobject 461.1 ns 405.6 ns +13.7%
❌ sequence_from_list 327.8 ns 383.3 ns -14.49%
❌ sequence_from_tuple 232.8 ns 260.6 ns -10.66%
View more details on CodSpeed HQ