Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PyErr::get_type_bound #3819

Merged
merged 9 commits into from
Feb 11, 2024
Merged

Conversation

LilyFoote
Copy link
Contributor

Implements more of the Bound api from #3684.

Copy link

codspeed-hq bot commented Feb 10, 2024

CodSpeed Performance Report

Merging #3819 will degrade performances by 16.95%

Comparing LilyFoote:pyerr-bound (c644893) with main (fa53d81)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main LilyFoote:pyerr-bound Change
list_via_extract 392.2 ns 336.7 ns +16.5%
not_a_list_via_downcast 216.7 ns 244.4 ns -11.36%
f64_from_pyobject 461.1 ns 405.6 ns +13.7%
sequence_from_list 272.2 ns 327.8 ns -16.95%

@LilyFoote LilyFoote mentioned this pull request Feb 11, 2024
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping out with our great API migration!

There's a few thorny edge cases with reference counting that I've caught here. Comments below...

src/err/err_state.rs Outdated Show resolved Hide resolved
src/err/mod.rs Outdated Show resolved Hide resolved
src/err/mod.rs Outdated Show resolved Hide resolved
src/err/mod.rs Outdated Show resolved Hide resolved
src/err/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 11, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Feb 11, 2024
Merged via the queue into PyO3:main with commit baf5c8e Feb 11, 2024
35 of 39 checks passed
@LilyFoote LilyFoote deleted the pyerr-bound branch February 11, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants