-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port Python::eval
to Bound
API
#3806
Conversation
CodSpeed Performance ReportMerging #3806 will degrade performances by 15.63%Comparing Summary
Benchmarks breakdown
|
cfbc3ce
to
6f2019f
Compare
Sorry for the slight delay, I will do my best to review this tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, this is a much more reviewable first step. Thanks again and sorry I was a bit stretched for time in the last couple of days!
globals.map(PyNativeType::as_borrowed).as_deref(), | ||
locals.map(PyNativeType::as_borrowed).as_deref(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 very tidy temporary solution!
Uff rust nightly change broke the merge. |
Rebased, to include CI fixes |
👍 sorry I forgot to rerun the merge queue, it should have automatically picked them up but I just got sidetracked. |
Part of #3684 and split from #3716
This converts to the
Python::eval
function to the new API. For easier reviewing this focuses purely oneval
/eval_bound
and leaves the very similarPython::run
method as well as thePyDict
methods for followup PRs.