Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PyDict::new_bound without deprecation #3772

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

davidhewitt
Copy link
Member

This is split from #3716, it's just the addition of PyDict::new_bound without any deprecation added or accompanying changes.

As this is a tiny diff which repeats exactly the pattern we've already established, I'm just going to merge immediately so other PRs can build on it.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jan 29, 2024
@davidhewitt davidhewitt enabled auto-merge January 29, 2024 10:20
Copy link

codspeed-hq bot commented Jan 29, 2024

CodSpeed Performance Report

Merging #3772 will improve performances by 24.75%

Comparing davidhewitt:dict-new-bound (d4d08b2) with main (c54d897)

Summary

⚡ 3 improvements
✅ 77 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:dict-new-bound Change
test_simple_py 34.7 µs 31.4 µs +10.48%
extract_int_downcast_fail 266.1 ns 238.3 ns +11.66%
mapping_from_dict 420 ns 336.7 ns +24.75%

@davidhewitt davidhewitt added this pull request to the merge queue Jan 29, 2024
Merged via the queue into PyO3:main with commit 7f2d1d2 Jan 29, 2024
39 checks passed
@davidhewitt davidhewitt deleted the dict-new-bound branch January 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants