Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove internal uses of _Py_NewRef #3765

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

davidhewitt
Copy link
Member

This is a part of #3762, specifically removing _Py_NewRef as something which PyO3 uses internally. It was straightforward to do this using safe APIs.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jan 27, 2024
Copy link

codspeed-hq bot commented Jan 27, 2024

CodSpeed Performance Report

Merging #3765 will degrade performances by 10.44%

Comparing davidhewitt:remove-py-newref (87e0610) with main (f449fc0)

Summary

❌ 1 regressions
✅ 77 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main davidhewitt:remove-py-newref Change
extract_int_downcast_fail 238.3 ns 266.1 ns -10.44%

@davidhewitt davidhewitt added this pull request to the merge queue Jan 27, 2024
Merged via the queue into PyO3:main with commit 5f320d7 Jan 27, 2024
38 of 39 checks passed
@davidhewitt davidhewitt deleted the remove-py-newref branch January 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants