begin drafting Bound<T> migration guide #3693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Dec 24, 2023
| In addition to the major API type overhaul, PyO3 has needed to make a few small breaking adjustments to other APIs to close correctness and soundness gaps. | ||
|
|
||
| The recommended steps to update to PyO3 0.21 is as follows: | ||
| 1. Add compatibility code to convert new `Bound<T>` smart pointers back to GIL Refs |
There was a problem hiding this comment.
Ok I think this is not the approach we are taking any more, I'll come back to rewrite this section later.
|
Superseded by #3707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a start of the migration guide to
Bound<T>. I think there's still a lot more to be added here, but I wanted to push this anyway so that we can have a central place to start collecting migration notes as well as agree on the way we want to communicate this to users.