Some boy scouting w.r.t. usage of our internal helper functions when handling collection ABC #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
approved these changes
Dec 21, 2023
| // TODO: surface errors in this chain to the user | ||
| .unwrap_or(false) | ||
| .unwrap_or_else(|err| { | ||
| err.write_unraisable(object.py(), Some(object)); |
There was a problem hiding this comment.
Using write_unraisable here is a very good idea 👍
CodSpeed Performance ReportMerging #3683 will improve performances by 39.42%Comparing Summary
Benchmarks breakdown
|
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
adamreichold
force-pushed
the
use-type-ref-helper
branch
from
fa32416 to
3c97167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.