Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrono: makes FromPyObject impl on DateTime generic #3663

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Chrono: makes FromPyObject impl on DateTime generic #3663

merged 1 commit into from
Dec 19, 2023

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Dec 18, 2023

ToPyObject was already generic

@Tpt Tpt force-pushed the chrono-generic-datetime branch from fabd043 to 4aa6b10 Compare December 18, 2023 19:11
@Tpt Tpt force-pushed the chrono-generic-datetime branch from 4aa6b10 to 0d2387e Compare December 18, 2023 19:12
adamreichold
adamreichold approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will not merge immediately so others can have a look as well.

davidhewitt
davidhewitt approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tpt, I wanted to do similar in the past too!

By the way there's a related issue here #3266 which you might find interesting / relevant while you look into all of this. 😅

@davidhewitt davidhewitt added this pull request to the merge queue Dec 19, 2023
Merged via the queue into PyO3:main with commit 12b44ea Dec 19, 2023
35 checks passed
@Tpt Tpt deleted the chrono-generic-datetime branch December 19, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tpt @davidhewitt @adamreichold