-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add coroutine::await_in_coroutine
to await awaitables in coroutine context
#3611
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #3611 will not alter performanceComparing 🎉 Hooray!
|
d1e9e17
to
53cccb4
Compare
@wyfo I'm sorry for the painfully slow review here. Given that Does this patch rely on #3610 getting merged, or is it possible to rebase this on main? That would allow us to move forward with some of these remaining async PRs. |
2eb4c74
to
732bb84
Compare
There is one thing bothering me with this implementation: the name I've chosen |
e15675f
to
053bfc2
Compare
The error in CI (other than |
2ebb268
to
18f59ea
Compare
coroutine::await_in_coroutine
to await awaitables in coroutine context
As written above, the name |
Relates to #1632
Draft based on #3610