-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all functionality deprecated in PyO3 0.18 #3232
Conversation
13e6005
to
beb4dde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Looks like this also removes the usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion to make the change log more explicit. LGTM otherwise.
I think what I'll do is split this out into separate PRs with separate changelog items, and merge them in turn given the approvals here. |
Actually I've changed my mind; I'll just update the CHANGELOG entry and also add a small migration guide entry. |
beb4dde
to
4f3fcdb
Compare
This turned out to be a very satisfying purge of complexity, mostly due to removing the backwards-compatibility for
#[pyfunction(a, b)]
and#[args(a, b)]
which have been replaced by#[pyo3(signature = (a, b))]
.