Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable v2 resolver on the workspace to enable dropping PYO3_CI workaround #3211

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

adamreichold
Copy link
Member

No description provided.

@adamreichold adamreichold added the CI-skip-changelog Skip checking changelog entry label Jun 5, 2023
@davidhewitt
Copy link
Member

How do you feel about instead going to 2021 edition, which I think implies resolver = 2?

(Could be a follow-up I guess?)

@adamreichold
Copy link
Member Author

How do you feel about instead going to 2021 edition, which I think implies resolver = 2?

(Could be a follow-up I guess?)

Yes, I would like to bump the edition separately.

It is trivial to remove the resolver = "2" line, but I would like to see the effects of this in isolation as environment variables are a classic case for spooky action at a distance in software.

@adamreichold
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jun 5, 2023
@bors
Copy link
Contributor

bors bot commented Jun 5, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 5, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 894b62f into main Jun 5, 2023
@bors bors bot deleted the resolver-v2 branch June 5, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants