Fix compile error when trying to use static slot methods, fixes: #3039 #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willstott101
changed the title
willstott101
force-pushed
the
static-slot-methods
branch
from
92e99e3
to
bcdb17d
Compare
birkenfeld
reviewed
Mar 18, 2023
willstott101
force-pushed
the
static-slot-methods
branch
from
eacafff
to
b057953
Compare
davidhewitt
approved these changes
Mar 23, 2023
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst having static slot methods is of dubious value in the first place, there's little reason not to support it by bringing the different function call macros more in-line with each other.
I had no idea which test file to use so I just made a new one...
test_methods.rshas no slots in and the test files that do use slots seem to be specific to their protocol. Let me know if you'd like the test somewhere else.Thanks!