docs: Precise the abscense of py: Python for the #[pyo3(signature)]
#2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Jan 29, 2023
There was a problem hiding this comment.
Thanks, good to have this in documentation! It also inspired me to add #2930 to further help users.
I just have one suggestion on wording here...
mejrs
approved these changes
Jan 31, 2023
|
Just one thing 🙂 error[E0425]: cannot find function, tuple struct or tuple variant `OK` in this scope
--> src/lib.rs:561:5
|
16 | OK(())
| ^^ help: a tuple variant with a similar name exists (notice the capitalization): `Ok` |
jjerphan
commented
Feb 2, 2023
mejrs
reviewed
Feb 2, 2023
bors bot
added a commit
that referenced
this pull request
Feb 3, 2023
2930: add better error message for Python in signature r=adamreichold a=davidhewitt Inspired by #2929, this just adds a better error message when `Python` arguments are accidentally included in the signature. Co-authored-by: David Hewitt <[email protected]>
davidhewitt
approved these changes
Feb 3, 2023
davidhewitt
force-pushed
the
docs/pyo3-signature-precise-py-argument
branch
from
2652cb7
to
9306d56
Compare
|
bors r+ |
|
Build succeeded: |
|
Thank you @davidhewitt ! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First, thank you for working on PyO3!
I think this adds a precision which was not obvious when migrating to 0.18.0 conventions.
What do you think? Also, should something be added to the migration guide in this regard?
Thank you!