Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyTzInfoAccess #2263

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Add PyTzInfoAccess #2263

merged 2 commits into from
Apr 13, 2022

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Mar 31, 2022

Thank you for contributing to pyo3!

Please consider adding the following to your pull request:

  • an entry in CHANGELOG.md
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

PyO3's CI pipeline will check your pull request. To run its tests
locally, you can run cargo xtask ci. See its documentation
here.

As discussed in #1588 (comment)

CHANGELOG.md Outdated Show resolved Hide resolved
src/types/datetime.rs Show resolved Hide resolved
@pickfire pickfire force-pushed the pytzinfoaccess branch 2 times, most recently from 0efd02b to e7326d2 Compare April 10, 2022 15:46
@davidhewitt davidhewitt mentioned this pull request Apr 10, 2022
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm maybe to avoid the dance with Python None we should just inline an equivalent of the FFI symbols.

src/types/datetime.rs Outdated Show resolved Hide resolved
src/types/datetime.rs Outdated Show resolved Hide resolved
src/types/datetime.rs Show resolved Hide resolved
@messense
Copy link
Member

@pickfire You need to resolve conflicts otherwise CI won't run.

Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidhewitt I think this is good to merge now. Do you concur? If so, I'll merge and rebase the 0.16.4 release branch.

@davidhewitt
Copy link
Member

That would be great; thanks & I'll put the release live tonight 👍

@adamreichold adamreichold merged commit c2d44ac into PyO3:main Apr 13, 2022
@pickfire pickfire deleted the pytzinfoaccess branch April 13, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants